Unmanage/Manage services and interfaces duplicated code and not sufficient events

Description

When managing/unmanaging services/interfaces the logic currently implemented is a bit maintenance unfriendly.

Basically we have two implementations:

./opennms-webapp/src/main/java/org/opennms/web/admin/nodeManagement/ManageNodesServlet.java
./opennms-webapp/src/main/java/org/opennms/web/admin/nodeManagement/ManageNodeServlet.java

Both do more or less the same.

In addition both implementations send different events.

The goal is to verify if both servlets can be unified.
In addition it should be verified which events should be sent.
I talked to Jeff about this and it seems that both implementations may not be optimal.
The following events should be send:

1. manage/unmanage a service
A serviceManaged or serviceUnmanaged event

2. manage/unmanage an interface
A interfaceManaged or interfaceUnmanaged event

3. resume/suspend poller
whenever a service changes from unmanaged to managed a POLLER RESUME event must be send
whenever a service changes from managed to unmanaged a POLLER SUSPEND event must be send.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Details

Assignee

Reporter

Labels

Components

Affects versions

Priority

PagerDuty

Created October 8, 2015 at 2:04 AM
Updated September 21, 2021 at 6:22 PM