Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

NPE on "manage and unmanage services and interfaces"

Description

Here are the steps to reproduce the problem.

1) Go to the node's page
2) Click on "Admin" (from the sub-tasks)
3) Click on "manage and unmanage services and interfaces"
4) Click on "Unselect all" (to force unmanage all the interfaces)
5) Click on "Apply"

After doing that, you get an error on the WebUI:

java.lang.NullPointerException
at java.util.Arrays$ArrayList.(Arrays.java:2842)
at java.util.Arrays.asList(Arrays.java:2828)
at org.opennms.web.admin.nodeManagement.ManageNodeServlet.doPost(ManageNodeServlet.java:115)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:652)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1317)
at org.opennms.container.web.felix.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:53)
at org.opennms.container.web.felix.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:35)
at org.opennms.container.web.felix.base.internal.dispatch.FilterPipeline.dispatch(FilterPipeline.java:50)
at org.opennms.container.web.felix.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:42)
at org.opennms.container.web.bridge.internal.DispatcherFilter.doFilter(DispatcherFilter.java:72)
at org.opennms.container.web.ProxyFilter.doFilter(ProxyFilter.java:56)

Environment

OpenNMS Version: 16.0.2 Java Version: 1.8.0_45 Oracle Corporation Operating System: Linux

Acceptance / Success Criteria

None

Attachments

4

Lucidchart Diagrams

Activity

Show:

Markus von Rüden October 8, 2015 at 2:05 AM
Edited

The issue was that no NP-Check was done in the handling servlet. However I think there are other issues with the logic implemented there. I created a follow up issue for that .

The Pull Request for this issue can be found at github: https://github.com/OpenNMS/opennms/pull/380

Murat Yildiz October 7, 2015 at 11:37 AM

1) i have attached the dump for ipinterface table.
it has only one data record and the 'ipinterface.ipstatus' field was never set on any record on my local db, nor is it queried to handle the logik in the source code.
Was that what you meant by 'unhandled content' ?
Actually i fixed it by adding null checks and it is in review now.

2) it shall be fixed in 17.0.0 too ?

Seth Leger October 7, 2015 at 10:27 AM

This probably is caused by some sort of invalid or unhandled content in the ipinterfaces table. Can you provide a dump of this table and attach it to the bug? Thanks.

Murat Yildiz October 2, 2015 at 5:43 AM

At least for version 16.0.2 i can now confirm the NPE.
I will double check for 16.0.1

Murat Yildiz October 1, 2015 at 10:29 PM

I still cannot reproduce the NPE.

I have attached screenshots of the System Info, and Apply Changes

Fixed

Details

Assignee

Reporter

Components

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created August 5, 2015 at 3:33 AM
Updated October 8, 2015 at 6:00 AM
Resolved October 8, 2015 at 2:06 AM