PM datasource does not fail gracefully when the query time outs
Description
Lucidchart Diagrams
Activity
Show:
Benjamin Reed April 5, 2018 at 3:53 PM
Jesse White April 4, 2018 at 6:42 PM
I don't think this relates to your changes, since the calls to testDatasource behave as expected.
Benjamin Reed April 4, 2018 at 6:15 PM
Ah, does my return at line 81 need to be a throw instead? https://github.com/OpenNMS/opennms-helm/blob/5780f786d96c536fea76104ffb4a35245448eda8/src/datasources/perf-ds/datasource.js#L81
When using the PM datasource in a Graph panel, if the HTTP request times out, the loading indicator on the panel keeps spinning and no error is shown.
I suspect this is due to the way the promise is handled, since the timeouts are handled properly when calls are made to
testDatasource.See https://github.com/OpenNMS/opennms-helm/blob/5780f786d96c536fea76104ffb4a35245448eda8/src/datasources/perf-ds/datasource.js#L63