Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

EventUtils.eventsMatch() fails if nodeId is greater than 127

Description

Comparing Long objects using the == operator fails for values greater than 127. The equals() method should be used, instead.

https://github.com/OpenNMS/opennms/blob/2ccf1b39b150232ae6bdac3274aefd6c58d1de8f/opennms-model/src/main/java/org/opennms/netmgt/model/events/EventUtils.java#L575

 

 

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Will Keaney April 2, 2018 at 6:00 PM

Yours is a bit more comprehensive, I'm happy to defer to it

Benjamin Reed April 2, 2018 at 5:57 PM

I can't believe I messed with this issue and then didn't scroll down to look at your comment that you already had a PR.  Just saw it was unassigned and went at it. 

Alternate PR for foundation-2016 here: https://github.com/OpenNMS/opennms/pull/1916

Will Keaney March 30, 2018 at 8:27 PM

Fixed

Details

Assignee

Reporter

Components

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created March 30, 2018 at 8:16 PM
Updated April 3, 2018 at 12:25 PM
Resolved April 3, 2018 at 12:25 PM