Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Value of ${nodeLabel} for PSM services apparently not eagerly updated

Description

One student had the label of his test node as my_local_host in the requisition. This broke the OpenNMS-Login PSM service because it includes virtual-host="${nodeLabel}". We changed the node label to a valid hostname and synchronized the requisition, then deleted the service and rescanned the node so that a poll would happen again right away. It should have gone green on that poll, but it failed again with the same message:

...because of the following condition: my_local_host

Restarting OpenNMS caused the outage to resolve. This leads me to conclude that the value of at least nodeLabel is not updated eagerly by the poller. I'm thinking the poller should refresh its cache of node labels et al when it sees a nodeUpdated event, that should resolve the problem.

Environment

Encountered while doing Unit 9 (PSM) of training syllabus

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Patrick Schweizer May 10, 2018 at 1:20 PM

Patrick Schweizer May 10, 2018 at 1:18 PM
Edited

The issue is caused by different parameters set and read on the event.

The parameters are set in OnmsNode.mergeNodeAttributes(), line 463 (EventConstants.PARM_OLD_NODE_LABEL and EventConstants.PARM_NEW_NODE_LABEL)

but in PollerEventProcessor.nodeLabelChangedHandler(), line 382 the parameter EventConstants.PARM_NODE_LABEL is checked

It seems we have 2 different ways of creating a NODE_UPDATED_EVENT, either with EventConstants.PARM_OLD_NODE_LABEL and EventConstants.PARM_NEW_NODE_LABEL or with EventConstants.PARM_NODE_LABEL (as done in the tests).

 

I fixed it by introducing a builder that ensures that the right attributes (EventConstants.PARM_OLD_NODE_LABEL and EventConstants.PARM_NEW_NODE_LABEL) are set. Using the generic builder will result in a warning (we could also be harsh and make it throw an exception)

Fixed

Details

Assignee

Reporter

Labels

Components

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created February 28, 2018 at 7:58 PM
Updated May 17, 2018 at 1:26 AM
Resolved May 17, 2018 at 1:26 AM

Flag notifications