BestMatchPingerFactory returns NullPinger when better options are available

Description

In some cases the BestMatchPingerFactory may return the NullPinger, even when other options should work i.e. the necessary JNI bits for the JICMP pinger are available, and the JNA pinger is functional.

When using the NullPinger, all ICMP requests "fail".

Restarting the JVM restores the appropriate pinger.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Benjamin Reed January 8, 2019 at 5:24 PM

PR for foundation-2017 should be building now: https://github.com/OpenNMS/opennms/pull/2310

Jesse White January 6, 2019 at 4:48 PM

I merged the PR that was targeted for foundation-2018, but looks like foundation-2017 may also be affected.

Benjamin Reed December 19, 2018 at 3:04 PM

Benjamin Reed December 19, 2018 at 3:04 PM

This works for me, and I've tried it on a couple of different systems (mac & linux) but I'd love a few folks to try it and let me know if they see any weirdness.

Benjamin Reed December 7, 2018 at 3:22 PM

I know that our "get local host" sometimes gets the local non-loopback IP instead of the local loopback one.  Wonder if that's what's going on here.

Fixed

Details

Assignee

Reporter

Components

Sprint

Priority

PagerDuty

Created September 29, 2017 at 3:34 PM
Updated January 9, 2019 at 3:04 PM
Resolved January 9, 2019 at 3:04 PM