Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

ScheduledOutagesRestServiceIT doesn't validate collectd configuration changes

Description

I'm trying to add methods to check that a particular scheduled outage is on a package in pollerd, collectd, and threshd. Its working for Pollerd & Threshd, but the unit test is failing for Collectd. Here is the added method to ScheduledOutagesRestService:

@GET @Path("{outageName}/collectd/{packageName}") @Produces(MediaType.TEXT_PLAIN) public String isOutageToCollectorPackage(@PathParam("outageName") String outageName, @PathParam("packageName") String packageName) { Outage outage = getOutage(outageName); if (outage == null) { throw getException(Status.NOT_FOUND, "Scheduled outage {} was not found.", outageName); } Package pkg = m_collectdConfigFactory.getCollectdConfig().getPackage(packageName); if (pkg == null) { throw getException(Status.NOT_FOUND, "Collectd package {} was not found.", packageName); } Boolean found = pkg.getOutageCalendars().contains(outageName); return found.toString(); }

And the modified method in ScheduledOutagesRestServiceIT:

@Test public void testUpdateCollectdConfig() throws Exception { sendRequest(PUT, "/sched-outages/my-junit-test/collectd/example1", 204); String out = sendRequest(GET, "/sched-outages/my-junit-test/collectd/example1", 200); Assert.assertEquals("collectd package example1 contains my-junit-test", "true", out); sendRequest(DELETE, "/sched-outages/my-junit-test/collectd/example1", 204); }

This test fails to pass the assertEquals.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Ron Roskens July 21, 2017 at 9:12 PM

If I update the unit test like this:

@Test public void testUpdateCollectdConfig() throws Exception { sendRequest(PUT, "/sched-outages/my-junit-test/collectd/example1", 204); sendRequest(PUT, "/sched-outages/my-junit-test/collectd/cassandra-via-jmx", 204); String out = sendRequest(GET, "/sched-outages/my-junit-test/collectd/example1", 200); Assert.assertEquals("collectd package example1 contains my-junit-test", "true", out); sendRequest(DELETE, "/sched-outages/my-junit-test/collectd/example1", 204); }

Then only the cassandra-via-jmx package has an outage-calendar entry for my-junit-test.

Details

Assignee

Reporter

Labels

Components

Priority

PagerDuty

Created July 21, 2017 at 8:30 PM
Updated September 21, 2021 at 6:22 PM

Flag notifications