Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Alarmd creates new database transaction for every event

Description

Alarmd's event listener is wrapped in a @Transactional annotation which will create a database transaction for every event, even those without alarm keys.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Alejandro Galue May 23, 2017 at 12:03 PM
Edited

The fix for this issue also solves a problem on BSMD. In Horizon 18, Alarmd was sending the alarmCreated event prior finishing the transaction, causing a problem in BSMD. The problem is that when BSMD receives that event, it tries to get the alarm from the database, and most of the time, it can't find it, and BSMD is unable to process that event. I validated that with 19, this doesn't happen, and BSM is able to process that event correctly.

In 18, messages like the following dominated almost 100% of the content of bsmd.log, even if you don't have business services on your system.

Seth Leger January 3, 2017 at 5:00 PM

PR merged, marking as fixed.

commit cf6b100b7ae692cc35420023a6f5df69390ff23b

Fixed

Details

Assignee

Reporter

Components

Sprint

Fix versions

Affects versions

Priority

Parent

PagerDuty

Created December 15, 2016 at 10:41 AM
Updated May 23, 2017 at 12:35 PM
Resolved January 3, 2017 at 5:00 PM