Add threshold comments and whitespace changes to match how the OpenNMS web GUI generates XML files
Description
This is a proposed patch that does the following:
1. thresholds.xml
Add descriptions to all thresholds to add documentation on what each threshold is for
Change whitespace and ordering to match how the OpenNMS web UI generates the file; I used the web GUI to open each threshold in the editor and then saved it WITH NO CHANGES (other than the description) to get OpenNMS just to rewrite the file formatting. The issue here is it is much easier to diff a new version of the file with the one in production if the whitespace and XML formatting match how the GUI edits the file.
2. eventconf.xml
Added a comment about file ordering for documentation purposes
Remove extraneous blank lines
Acceptance / Success Criteria
None
Lucidchart Diagrams
Activity
Show:
Ronny Trommer January 12, 2016 at 10:20 AM
Merged to foundation-2016
Ronny Trommer January 11, 2016 at 11:39 AM
Updated to latest develop branch to be able to compile it and get it through CI.
Hi Seth, thanks for the feedback. I have revised the proposed patch as per your comment.
Regards, Tim
Seth Leger December 18, 2015 at 10:11 AM
Hi Tim,
I would prefer that we leave the blank lines in the eventconf.xml file since they divide up the logical sections of the events. Can you redo the patch without the blank line removals? Thanks.
This is a proposed patch that does the following:
1. thresholds.xml
Add descriptions to all thresholds to add documentation on what each threshold is for
Change whitespace and ordering to match how the OpenNMS web UI generates the file; I used the web GUI to open each threshold in the editor and then saved it WITH NO CHANGES (other than the description) to get OpenNMS just to rewrite the file formatting. The issue here is it is much easier to diff a new version of the file with the one in production if the whitespace and XML formatting match how the GUI edits the file.
2. eventconf.xml
Added a comment about file ordering for documentation purposes
Remove extraneous blank lines