Fixed in release-16.0.1 and develop with 1d521b89dbdc602050d443f951373de0932ed854.

I'm still unable to reproduce this on my test system, the label gets updated successfully. However, the stack trace does identify the cause. We need to wrap the call in a transaction context.

I've made this change here: https://github.com/OpenNMS/opennms/commit/1d521b89dbdc602050d443f951373de0932ed854

Here is the code for NodeLabelDaoImpl:

https://github.com/OpenNMS/opennms/blob/opennms-16.0.0-1/opennms-dao/src/main/java/org/opennms/netmgt/dao/hibernate/NodeLabelDaoImpl.java

The method assignLabel has some debug lines, so I've enabled DEBUG for web on log4j2.xml, and here is what I got:

So, looking carefully at the exception I found that the controller is manually instantiating a NodeLabelDaoImpl which in my personal opinion is not correct, considering that this class is supposed to be managed through Spring (because it has autowired dependencies against NodeDao). I think that could be the reason. Probably the best solution is to migrate that servlet to be Spring MVC to properly inject NodeLabelDao and use it.

I'm attaching web.log with the full stack trace for both options, but here is the relevant content:

web.log

I think I have an idea about what could be happening but I would like some input from Scott.

Change the node's label for a node only makes sense for discovered nodes. Actually in OpenNMS 16, the link to change the node's label doesn't appear on requisitioned nodes, so that should not be a confusion anymore in 16.

Now, if I go to the node's label change page from the node's page (after clicking on Admin on the node's page toolbar and then "Change Node Label"), choose a name for "User Defined" and click "Change Label", I get a org.springframework.dao.InvalidDataAccessApiUsageException exception. Of course, the label is not changed.

So, still DNS label, repeat the process again and just click "Change Label" (without changing anything else), I got the exception again. I think this is the problem reported by Scott.

I think this is obvious, but you should add a node through "Add Interface" (i.e. a discovered).