Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

IpInterfaceScan shouldDetect() method should check for empty string in addition to null string

Description

I'm writing a detector for protocol XMP.

My XmpDetector was returning empty string for ipMatch method and IpInterfaceScan shouldDetect() method was only checking for null string. Null string and empty string are semantically same but code was not catching.

I added check for empty string to shouldDetect() and am testing now. I will submit enhancement with my XmpDetector via my pull request.

Thanks,

Bobby

Environment

All

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Benjamin Reed January 27, 2015 at 11:50 AM

Easy fix. Fixed in foundation -> develop.

Fixed

Details

Assignee

Reporter

Original estimate

Time tracking

No time logged1h remaining

Components

Fix versions

Affects versions

Priority

PagerDuty

Created January 27, 2015 at 10:29 AM
Updated April 7, 2015 at 3:03 PM
Resolved January 27, 2015 at 11:50 AM