test failure: org.opennms.web.springframework.security.SecurityAuthenticationEventOnmsEventBuilderTest

Description

Looks like another race condition: http://bamboo.internal.opennms.com:8085/browse/OPENNMS-NMS90-UNIT-6/test/case/105318116

java.lang.AssertionError:
Unexpected method call EventProxy.send(org.opennms.netmgt.xml.event.Event@733d0fc[uuid=<null>,dbid=<null>,dist-poller=<null>,creation-time=Thursday, September 25, 2014 6:39:06 PM GMT,master-station=<null>,mask=<null>,uei=uei.opennms.org/internal/authentication/failure,source=OpenNMS.WebUI,nodeid=<null>,time=Thursday, September 25, 2014 6:39:05 PM GMT,host=<null>,interface=<null>,snmphost=<null>,service=<null>,snmp=<null>,parms=[org.opennms.netmgt.xml.event.Parm@3244eabe[parmName=user,value=org.opennms.netmgt.xml.event.Value@15b3bfc5[content=bar,type=string,encoding=text]], org.opennms.netmgt.xml.event.Parm@4a8f79ba[parmName=ip,value=org.opennms.netmgt.xml.event.Value@4bf329a4[content=1.2.3.4,type=string,encoding=text]], org.opennms.netmgt.xml.event.Parm@1180c894[parmName=exceptionName,value=org.opennms.netmgt.xml.event.Value@4932f4f0[content=BadCredentialsException,type=string,encoding=text]], org.opennms.netmgt.xml.event.Parm@1df07586[parmName=exceptionMessage,value=org.opennms.netmgt.xml.event.Value@306ede1b[content=you are bad!,type=string,encoding=text]]],descr=<null>,logmsg=<null>,severity=<null>,pathoutage=<null>,correlation=<null>,operinstruct=<null>,autoaction=[],operaction=[],autoacknowledge=<null>,loggroup=[],tticket=<null>,forward=[],script=[],ifIndex=<null>,ifAlias=<null>,mouseovertext=<null>,alarm-data=<null>]):
EventProxy.send(eqEvent(Event:
CreationTime: Thursday, September 25, 2014 6:39:06 PM GMT
Dbid: 0
Nodeid: 0
Parms: {
user = string(text): bar
(15 more lines...)

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Benjamin Reed September 26, 2014 at 2:41 PM

added the ability to give some fudge factor in time comparisons

Seth Leger September 25, 2014 at 6:00 PM

This caused because the mock expectation is being set up with time "Thursday, September 25, 2014 9:30:27 PM GMT" and then the test is running 1ms later, just as the time has turned to "Thursday, September 25, 2014 9:30:28 PM GMT". We need to change the comparison to be tolerant of executing precisely on the second boundary.

Seth Leger September 25, 2014 at 5:51 PM

Here's the full output on my machine:

Seth Leger September 25, 2014 at 5:32 PM

I think I just reproduced this on my machine.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created September 25, 2014 at 2:42 PM
Updated September 26, 2014 at 6:40 PM
Resolved September 26, 2014 at 2:41 PM