lldpchassisid not properly decoded for DragonWave in Enhanced Linkd Lldp node discovery
Description
Acceptance / Success Criteria
Lucidchart Diagrams
Activity
Antonio Russo March 13, 2015 at 2:52 AM
Merged to develop release-15.0.2 foundation
615bf64..d0d4411 develop -> develop
314e5f5..0afa9bf release-15.0.2 -> release-15.0.2
5315d93..5929cfd foundation -> foundation
Antonio Russo March 12, 2015 at 9:07 AM
Cherry Pick:
MacBook-Pro-di-Antonio-Russo:opennms antonio$ git cherry-pick 89e849ebec9f55545e46eba1b16a180e988fa3c9
[features/foundation-enlinkd a77ae91] Fix : lldpchassisid not properly decoded for DragonWave
10 files changed, 560 insertions, 175 deletions
delete mode 100644 opennms-services/src/main/java/org/opennms/netmgt/enlinkd/snmp/LldpHelper.java
create mode 100644 opennms-services/src/test/java/org/opennms/netmgt/enlinkd/Nms7777DWEnTest.java
create mode 100644 opennms-services/src/test/java/org/opennms/netmgt/nb/Nms7777DWNetworkBuilder.java
create mode 100644 opennms-services/src/test/resources/linkd/nms7777dw/dw-walk.txt
MacBook-Pro-di-Antonio-Russo:opennms antonio$ git cherry-pick e14c050347baed73d0566632b85f47a9f2d17e98[features/foundation-enlinkd 2a039d1] Fix : Added a null check for chassis sub type
2 files changed, 19 insertions, 7 deletions
and pushed!
Antonio Russo March 12, 2015 at 7:32 AM
Cherry-pick to:
MacBook-Pro-di-Antonio-Russo:opennms antonio$ git cherry-pick 89e849ebec9f55545e46eba1b16a180e988fa3c9
[features/15.0.2-enlinkd 72a2ca0] Fix : lldpchassisid not properly decoded for DragonWave
10 files changed, 560 insertions, 175 deletions
delete mode 100644 opennms-services/src/main/java/org/opennms/netmgt/enlinkd/snmp/LldpHelper.java
create mode 100644 opennms-services/src/test/java/org/opennms/netmgt/enlinkd/Nms7777DWEnTest.java
create mode 100644 opennms-services/src/test/java/org/opennms/netmgt/nb/Nms7777DWNetworkBuilder.java
create mode 100644 opennms-services/src/test/resources/linkd/nms7777dw/dw-walk.txt
MacBook-Pro-di-Antonio-Russo:opennms antonio$ git cherry-pick e14c050347baed73d0566632b85f47a9f2d17e98
[features/15.0.2-enlinkd 4930c5c] Fix : Added a null check for chassis sub type
2 files changed, 19 insertions, 7 deletions
and pushed!
Antonio Russo March 12, 2015 at 6:20 AM
Need to be reworked de to test failures:
new commit...
commit e14c050347baed73d0566632b85f47a9f2d17e98
Author: Antonio <rssntn67@yahoo.it>
Date: Thu Mar 12 11:12:32 2015 +0100
Fix : Added a null check for chassis sub type
pushed to features/16.0-enlinkd
Antonio Russo March 11, 2015 at 2:00 PM
Pushed!
Counting objects: 198, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (35/35), done.
Writing objects: 100% (41/41), 18.98 KiB | 0 bytes/s, done.
Total 41 (delta 19), reused 0 (delta 0)
To git@github.com:OpenNMS/opennms.git
84a2681..12e1a6b features/16.0-enlinkd -> features/16.0-enlinkd
Details
Assignee
Antonio RussoAntonio RussoReporter
Antonio RussoAntonio RussoComponents
Fix versions
Affects versions
Priority
Major
Details
Details
Assignee
Antonio RussoReporter
Antonio RussoComponents
Fix versions
Affects versions
Priority
MajorPagerDuty
PagerDuty Incident
PagerDuty
PagerDuty Incident
PagerDuty
Here is the output from a query:
nodesysoid | nodesysdescription | lldpchassisid | lldpchassisidsubtype | lldpsysname
-------------------------------------------------------------------------------------------------------- .1.3.6.1.4.1.7262.2.4 | hz40_277_256qam Omni: 1.1.5.1 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.2.0 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.1.5.1 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.2.0 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hz40_142_32qam Omni: 1.2.0 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.1.5.1 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hz40_277_256qam Omni: 1.1.5.1 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.1.5.1 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.1.5.1 | � | 1 | NuDesign
.1.3.6.1.4.1.7262.2.4 | hx50_358_256qam Omni: 1.3.5 | � | 1 | NuDesign
Another important point is that those are all the different device with the same lldpsysid...and this will break the building links....of the Topology Ptovider.
opennms=# select n.nodesysoid, n.nodesysdescription, e.lldpchassisid, e.lldpchassisidsubtype, e.lldpsysname,n.nodesysname from lldpelement e left join node n on n.nodeid = e.nodeid where lldpchassisidsubtype = 1;
nodesysoid | nodesysdescription | lldpchassisid | lldpchassisidsubtype | lldpsysname | nodesysname
-------------------------------------------------------------------------------------------------------+-------------------------- .1.3.6.1.4.1.7262.2.4 | hz40_277_256qam Omni: 1.1.5.1 | � | 1 | NuDesign | LAX0022-DWHQ11-LAX0024
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.2.0 | � | 1 | NuDesign | LAX0016-DWHQ23-LAX0044-CA
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.1.5.1 | � | 1 | NuDesign | LAX0043-DWHQ23-LAX0016
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.2.0 | � | 1 | NuDesign | LAX0044-DWHQ23-LAX0016-CA
.1.3.6.1.4.1.7262.2.4 | hz40_142_32qam Omni: 1.2.0 | � | 1 | NuDesign | HOU0007-DWHQ11-HOU0008
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.1.5.1 | � | 1 | NuDesign | LAX0016-DWHQ18-LAX0037
.1.3.6.1.4.1.7262.2.4 | hz40_277_256qam Omni: 1.1.5.1 | � | 1 | NuDesign | LAX0024-DWHQ11-LAX0036
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.1.5.1 | � | 1 | NuDesign | LAX0023-DWHQ23-LAX0045
.1.3.6.1.4.1.7262.2.4 | hz50_364_256qam Omni: 1.1.5.1 | � | 1 | NuDesign | LAX0045-DWHQ23-LAX0023
.1.3.6.1.4.1.7262.2.4 | hx50_358_256qam Omni: 1.3.5 | � | 1 | NuDesign | BOS0070-DWHQ23-BOS0001