Many graph definitions in snmp-graph.properties have line continuation slashes

Description

There are a dozen or so newer definitions in snmp-graph.properties that contain a trailing "\" which will error out the graph to not display.

see

report.onms.collectd.threadpool.name=OpenNMS Collectd ThreadPool
report.onms.collectd.threadpool.columns=ONMSCollectPoolThrd, ONMSCollectPoolMax, ONMSCollectPoolPeak

...

GPRINT:max:AVERAGE:"Avg
: %5.0lf\" \ GPRINT:max:MIN:"Min
: %5.0lf" \ GPRINT:max:MAX:"Max
: %5.0lf
n" \

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Seth Leger January 26, 2015 at 12:15 PM

Fixed in foundation branch.

commit 544f578899fa59bc226aa74e4a5cb0c56b0462ed

Seth Leger January 22, 2015 at 2:59 PM

I'll work on applying this patch.

Ken Eshelby October 29, 2014 at 3:05 PM
Edited

$ cat 0001-KSE-removed-line-continuations-and-fixed-graph-name.patch From 438c843c6b1539ab97a2cb330966d9bae4c1df08 Mon Sep 17 00:00:00 2001 From: Ken Eshelby <ken@opennms.org> Date: Wed, 29 Oct 2014 12:00:31 -0700 Subject: [PATCH] KSE - removed line continuations and fixed graph name --- .../src/main/filtered/etc/snmp-graph.properties | 68 +++++++++++----------- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/opennms-base-assembly/src/main/filtered/etc/snmp-graph.properties b/opennms-base-assembly/src/main/filtered/etc/snmp-graph.properties index 76cc5fc..55e6ff7 100644 --- a/opennms-base-assembly/src/main/filtered/etc/snmp-graph.properties +++ b/opennms-base-assembly/src/main/filtered/etc/snmp-graph.properties @@ -126,7 +126,7 @@ report.onms.queued.updates.command=--title="OpenNMS Queued Updates" \ GPRINT:updates:MIN:"Min \\: %8.2lf %s" \ GPRINT:updates:MAX:"Max \\: %8.2lf %s\\n" -report.onms.queued.pending.name=OpenNMS Queued Updates +report.onms.queued.pending.name=OpenNMS Queued Operations Pending report.onms.queued.pending.columns=ONMSQueOpsPend report.onms.queued.pending.type=interfaceSnmp report.onms.queued.pending.command=--title="OpenNMS Queued Operations Pending" \ @@ -243,7 +243,7 @@ report.OpenNMS.Capsd.ActiveSuspecThreads.AttributeReport.command=--title="Active LINE2:ActiveSuspecThreads#c4a000:"ActiveSuspectThreads" \ GPRINT:ActiveSuspecThreads:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:ActiveSuspecThreads:MIN:" Min \\: %8.2lf %s" \ - GPRINT:ActiveSuspecThreads:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:ActiveSuspecThreads:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -259,7 +259,7 @@ report.OpenNMS.Capsd.ActiveRescanThreads.AttributeReport.command=--title="Active LINE2:ActiveRescanThreads#c4a000:"ActiveRescanThreads" \ GPRINT:ActiveRescanThreads:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:ActiveRescanThreads:MIN:" Min \\: %8.2lf %s" \ - GPRINT:ActiveRescanThreads:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:ActiveRescanThreads:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -275,7 +275,7 @@ report.OpenNMS.Capsd.SuspectCompletTasks.AttributeReport.command=--title="Suspec LINE2:SuspectCompletTasks#c4a000:"SuspectCompletedTasks" \ GPRINT:SuspectCompletTasks:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:SuspectCompletTasks:MIN:" Min \\: %8.2lf %s" \ - GPRINT:SuspectCompletTasks:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:SuspectCompletTasks:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -291,7 +291,7 @@ report.OpenNMS.Capsd.RescanCompletTasks.AttributeReport.command=--title="RescanC LINE2:RescanCompletTasks#c4a000:"RescanCompletedTasks" \ GPRINT:RescanCompletTasks:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:RescanCompletTasks:MIN:" Min \\: %8.2lf %s" \ - GPRINT:RescanCompletTasks:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:RescanCompletTasks:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -307,7 +307,7 @@ report.OpenNMS.Capsd.SuspectTotalTasks.AttributeReport.command=--title="SuspectT LINE2:SuspectTotalTasks#c4a000:"SuspectTotalTasks" \ GPRINT:SuspectTotalTasks:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:SuspectTotalTasks:MIN:" Min \\: %8.2lf %s" \ - GPRINT:SuspectTotalTasks:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:SuspectTotalTasks:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -323,7 +323,7 @@ report.OpenNMS.Capsd.RescanTotalTasks.AttributeReport.command=--title="RescanTot LINE2:RescanTotalTasks#c4a000:"RescanTotalTasks" \ GPRINT:RescanTotalTasks:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:RescanTotalTasks:MIN:" Min \\: %8.2lf %s" \ - GPRINT:RescanTotalTasks:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:RescanTotalTasks:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -339,7 +339,7 @@ report.OpenNMS.Capsd.SuspTaskComplRatio.AttributeReport.command=--title="Suspect LINE2:SuspTaskComplRatio#c4a000:"SuspectTaskCompletionRatio" \ GPRINT:SuspTaskComplRatio:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:SuspTaskComplRatio:MIN:" Min \\: %8.2lf %s" \ - GPRINT:SuspTaskComplRatio:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:SuspTaskComplRatio:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -355,7 +355,7 @@ report.OpenNMS.Capsd.RescTaskComplRatio.AttributeReport.command=--title="RescanT LINE2:RescTaskComplRatio#c4a000:"RescanTaskCompletionRatio" \ GPRINT:RescTaskComplRatio:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:RescTaskComplRatio:MIN:" Min \\: %8.2lf %s" \ - GPRINT:RescTaskComplRatio:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:RescTaskComplRatio:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -371,7 +371,7 @@ report.OpenNMS.Capsd.SuspectQueueSize.AttributeReport.command=--title="SuspectQu LINE2:SuspectQueueSize#c4a000:"SuspectQueueSize" \ GPRINT:SuspectQueueSize:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:SuspectQueueSize:MIN:" Min \\: %8.2lf %s" \ - GPRINT:SuspectQueueSize:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:SuspectQueueSize:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -387,7 +387,7 @@ report.OpenNMS.Capsd.RescanQueueSize.AttributeReport.command=--title="RescanQueu LINE2:RescanQueueSize#c4a000:"RescanQueueSize" \ GPRINT:RescanQueueSize:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:RescanQueueSize:MIN:" Min \\: %8.2lf %s" \ - GPRINT:RescanQueueSize:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:RescanQueueSize:MAX:" Max \\: %8.2lf %s\\n" @@ -404,7 +404,7 @@ report.OpenNMS.JettyServer.HttpsConnTotal.AttributeReport.command=--title="Https LINE2:HttpsConnTotal#c4a000:"HttpsConnectionsTotal" \ GPRINT:HttpsConnTotal:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:HttpsConnTotal:MIN:" Min \\: %8.2lf %s" \ - GPRINT:HttpsConnTotal:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:HttpsConnTotal:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -420,7 +420,7 @@ report.OpenNMS.JettyServer.HttpsConnOpen.AttributeReport.command=--title="HttpsC LINE2:HttpsConnOpen#c4a000:"HttpsConnectionsOpen" \ GPRINT:HttpsConnOpen:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:HttpsConnOpen:MIN:" Min \\: %8.2lf %s" \ - GPRINT:HttpsConnOpen:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:HttpsConnOpen:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -436,7 +436,7 @@ report.OpenNMS.JettyServer.HttpsConnOpenMax.AttributeReport.command=--title="Htt LINE2:HttpsConnOpenMax#c4a000:"HttpsConnectionsOpenMax" \ GPRINT:HttpsConnOpenMax:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:HttpsConnOpenMax:MIN:" Min \\: %8.2lf %s" \ - GPRINT:HttpsConnOpenMax:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:HttpsConnOpenMax:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -452,7 +452,7 @@ report.OpenNMS.JettyServer.HttpConnTotal.AttributeReport.command=--title="HttpCo LINE2:HttpConnTotal#c4a000:"HttpConnectionsTotal" \ GPRINT:HttpConnTotal:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:HttpConnTotal:MIN:" Min \\: %8.2lf %s" \ - GPRINT:HttpConnTotal:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:HttpConnTotal:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -468,7 +468,7 @@ report.OpenNMS.JettyServer.HttpConnOpen.AttributeReport.command=--title="HttpCon LINE2:HttpConnOpen#c4a000:"HttpConnectionsOpen" \ GPRINT:HttpConnOpen:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:HttpConnOpen:MIN:" Min \\: %8.2lf %s" \ - GPRINT:HttpConnOpen:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:HttpConnOpen:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -484,7 +484,7 @@ report.OpenNMS.JettyServer.HttpConnOpenMax.AttributeReport.command=--title="Http LINE2:HttpConnOpenMax#c4a000:"HttpConnectionsOpenMax" \ GPRINT:HttpConnOpenMax:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:HttpConnOpenMax:MIN:" Min \\: %8.2lf %s" \ - GPRINT:HttpConnOpenMax:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:HttpConnOpenMax:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -500,7 +500,7 @@ report.OpenNMS.Statsd.StaReportsStarted.AttributeReport.command=--title="Reports LINE2:StaReportsStarted#c4a000:"ReportsStarted" \ GPRINT:StaReportsStarted:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:StaReportsStarted:MIN:" Min \\: %8.2lf %s" \ - GPRINT:StaReportsStarted:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:StaReportsStarted:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -516,7 +516,7 @@ report.OpenNMS.Statsd.StaReportsCompleted.AttributeReport.command=--title="Repor LINE2:StaReportsCompleted#c4a000:"ReportsCompleted" \ GPRINT:StaReportsCompleted:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:StaReportsCompleted:MIN:" Min \\: %8.2lf %s" \ - GPRINT:StaReportsCompleted:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:StaReportsCompleted:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -532,7 +532,7 @@ report.OpenNMS.Statsd.StaReportsPersisted.AttributeReport.command=--title="Repor LINE2:StaReportsPersisted#c4a000:"ReportsPersisted" \ GPRINT:StaReportsPersisted:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:StaReportsPersisted:MIN:" Min \\: %8.2lf %s" \ - GPRINT:StaReportsPersisted:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:StaReportsPersisted:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -548,7 +548,7 @@ report.OpenNMS.Statsd.StaReportRunTime.AttributeReport.command=--title="ReportRu LINE2:StaReportRunTime#c4a000:"ReportRunTime" \ GPRINT:StaReportRunTime:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:StaReportRunTime:MIN:" Min \\: %8.2lf %s" \ - GPRINT:StaReportRunTime:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:StaReportRunTime:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -576,7 +576,7 @@ report.OpenNMS.Trapd.TrapsReceived.command=--title="Traps Received by Version" \ LINE2:V1TrapsReceived#204a87:"SNMPv1 " \ GPRINT:V1TrapsReceived:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:V1TrapsReceived:MIN:" Min \\: %8.2lf %s" \ - GPRINT:V1TrapsReceived:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:V1TrapsReceived:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -592,7 +592,7 @@ report.OpenNMS.Trapd.TrapsDiscarded.AttributeReport.command=--title="Traps Inten LINE2:TrapsDiscarded#c4a000:"Discarded" \ GPRINT:TrapsDiscarded:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:TrapsDiscarded:MIN:" Min \\: %8.2lf %s" \ - GPRINT:TrapsDiscarded:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:TrapsDiscarded:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -608,7 +608,7 @@ report.OpenNMS.Trapd.TrapsErrored.AttributeReport.command=--title="Traps with Er LINE2:TrapsErrored#c4a000:"Errored" \ GPRINT:TrapsErrored:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:TrapsErrored:MIN:" Min \\: %8.2lf %s" \ - GPRINT:TrapsErrored:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:TrapsErrored:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -624,7 +624,7 @@ report.OpenNMS.Notifd.NotificTasksQueued.AttributeReport.command=--title="Notifi LINE2:NotificTasksQueued#c4a000:"Queued" \ GPRINT:NotificTasksQueued:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:NotificTasksQueued:MIN:" Min \\: %8.2lf %s" \ - GPRINT:NotificTasksQueued:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:NotificTasksQueued:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -640,7 +640,7 @@ report.OpenNMS.Notifd.BinaryNoticeAttemp.AttributeReport.command=--title="Binary LINE2:BinaryNoticeAttemp#c4a000:"Attempted" \ GPRINT:BinaryNoticeAttemp:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:BinaryNoticeAttemp:MIN:" Min \\: %8.2lf %s" \ - GPRINT:BinaryNoticeAttemp:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:BinaryNoticeAttemp:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -656,7 +656,7 @@ report.OpenNMS.Notifd.JavaNoticesAttempt.AttributeReport.command=--title="Java N LINE2:JavaNoticesAttempt#c4a000:"Attempted" \ GPRINT:JavaNoticesAttempt:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:JavaNoticesAttempt:MIN:" Min \\: %8.2lf %s" \ - GPRINT:JavaNoticesAttempt:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:JavaNoticesAttempt:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -672,7 +672,7 @@ report.OpenNMS.Notifd.BinaryNoticeSuccee.AttributeReport.command=--title="Binary LINE2:BinaryNoticeSuccee#c4a000:"Succeeded" \ GPRINT:BinaryNoticeSuccee:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:BinaryNoticeSuccee:MIN:" Min \\: %8.2lf %s" \ - GPRINT:BinaryNoticeSuccee:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:BinaryNoticeSuccee:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -688,7 +688,7 @@ report.OpenNMS.Notifd.JavaNoticesSucceed.AttributeReport.command=--title="Java N LINE2:JavaNoticesSucceed#c4a000:"Succeeded" \ GPRINT:JavaNoticesSucceed:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:JavaNoticesSucceed:MIN:" Min \\: %8.2lf %s" \ - GPRINT:JavaNoticesSucceed:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:JavaNoticesSucceed:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -704,7 +704,7 @@ report.OpenNMS.Notifd.BinaryNoticeFailed.AttributeReport.command=--title="Binary LINE2:BinaryNoticeFailed#c4a000:"Failed" \ GPRINT:BinaryNoticeFailed:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:BinaryNoticeFailed:MIN:" Min \\: %8.2lf %s" \ - GPRINT:BinaryNoticeFailed:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:BinaryNoticeFailed:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -720,7 +720,7 @@ report.OpenNMS.Notifd.JavaNoticesFailed.AttributeReport.command=--title="Java No LINE2:JavaNoticesFailed#c4a000:"Failed" \ GPRINT:JavaNoticesFailed:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:JavaNoticesFailed:MIN:" Min \\: %8.2lf %s" \ - GPRINT:JavaNoticesFailed:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:JavaNoticesFailed:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -736,7 +736,7 @@ report.OpenNMS.Notifd.BinaryNoticeInterr.AttributeReport.command=--title="Binary LINE2:BinaryNoticeInterr#c4a000:"Interrupted" \ GPRINT:BinaryNoticeInterr:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:BinaryNoticeInterr:MIN:" Min \\: %8.2lf %s" \ - GPRINT:BinaryNoticeInterr:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:BinaryNoticeInterr:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -752,7 +752,7 @@ report.OpenNMS.Notifd.JavaNoticesInterru.AttributeReport.command=--title="Java N LINE2:JavaNoticesInterru#c4a000:"Interrupted" \ GPRINT:JavaNoticesInterru:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:JavaNoticesInterru:MIN:" Min \\: %8.2lf %s" \ - GPRINT:JavaNoticesInterru:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:JavaNoticesInterru:MAX:" Max \\: %8.2lf %s\\n" ########################################### @@ -768,7 +768,7 @@ report.OpenNMS.Notifd.UnknowNoticeInterr.AttributeReport.command=--title="Unknow LINE2:UnknowNoticeInterr#c4a000:"Interrupted" \ GPRINT:UnknowNoticeInterr:AVERAGE:" Avg \\: %8.2lf %s" \ GPRINT:UnknowNoticeInterr:MIN:" Min \\: %8.2lf %s" \ - GPRINT:UnknowNoticeInterr:MAX:" Max \\: %8.2lf %s\\n" \ + GPRINT:UnknowNoticeInterr:MAX:" Max \\: %8.2lf %s\\n" ## EOF -- 1.8.3.2
Fixed

Details

Assignee

Reporter

Labels

Affects versions

Priority

PagerDuty

Created September 9, 2014 at 12:49 PM
Updated April 7, 2015 at 3:04 PM
Resolved January 26, 2015 at 12:15 PM

Flag notifications