Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Eventd does not honor reloadDaemonConfig event

Description

Eventd is meant to recognize the reloadDaemonConfig event as equivalent to the old eventsConfigChanged event, but it does not. The code is all present to handle the newer event, but Eventd's BroadcastEventProcessor class never registers for it so the code is never reached.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Jeff Gehlbach April 13, 2016 at 10:30 AM

Original PR targeted wrong branch. New PR:

https://github.com/OpenNMS/opennms/pull/715

Bamboo is now green.

Jeff Gehlbach April 11, 2016 at 1:16 PM

Jeff Gehlbach April 11, 2016 at 1:07 PM

The use of EventUtils.getValueOfParm( String, Event ) seems to be an error. This method looks designed for expanding tokens like %nodelabel% or %parm[foo]% (which could refer to fields or parameters or other things) rather than for getting the value of a parameter which we know to be a Parm. Changing to Event.getParm( String ) seems like the right thing to do here.

Jeff Gehlbach April 8, 2016 at 11:39 AM

helped me hitch up a debugger and track down the cause of this regression. Seems related to the change in Eventd's BroadcastEventProcessor class from using EventUtils.getParmValue( String ) to a crazy-looking style involving AbstractEventUtils to check the value of the PARM_DAEMON_NAME parameter. This was probably done as part of refactoring Eventd from opennms-services into features/events/daemon Switching to Event.getParm( String ) lets it work correctly again. We should track down why the AbstractEventUtils code path doesn't work, I think

Jeff Gehlbach March 20, 2016 at 1:46 PM

Bumping this one... we really need to get these old UEIs out of circulation.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created May 7, 2014 at 5:04 PM
Updated August 2, 2017 at 1:42 PM
Resolved April 13, 2016 at 2:57 PM