Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

log4j.properties needs a comment for instrumentation.log default DEBUG level

Description

By default, instrumentation.log default logging level is DEBUG. This is good because it allows the Instrumentation Log Reader to collect time differences and do it's job in the UI.

This is bad, because users going through logging will tend to set this to a higher level, such as WARN. A simple fix could be a comment to the effect of:

(log4j.properties)

  1. Instrumentation

  2. NOTE: Instrumentation logging is set to DEBUG by default to allow Instrumentation Log Reader functionality
    log4j.category.Instrumentation=DEBUG, INSTRUMENT

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Seth Leger June 20, 2016 at 12:39 AM

Comments were added during the switchover to log4j2. Marking as fixed.

commit 48ceb8341e6d32288d8bf0e3f0206fbd5065397f

Ron Roskens October 30, 2014 at 11:39 PM

For 14, log4j2.xml shows this:

<!-- always leave instrumentation logging at INFO -->
<KeyValuePair key="instrumentation" value="INFO" />

It might make sense to update the comment to be:

<!-- Always leave instrumentation logging at INFO to allow Instrumentation Log Reader functionality -->

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created February 18, 2014 at 3:12 PM
Updated June 20, 2016 at 12:39 AM
Resolved June 20, 2016 at 12:39 AM