Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Alarm Details for an not existing alarm shows empty page.

Description

When you go to an alarm detail page for an alarm which does not exist, you get an empty white page.

But instead of the white page you should get an error message like "Alarm ID not found." (like it shows up for an event which is not present).

To reproduce you could try this: http://localhost:8980/opennms/alarm/detail.htm?id=999999999999

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Seth Leger December 4, 2013 at 4:39 PM

The problem here was that the OSGi http service bridge code was catching all exceptions inside its servlet filter. This prevented the exceptions from bubbling up and triggering the error-page directives in the UI.

I took out the exception catch and backported some fixes for the smoke tests into 1.12 that will catch this problem. Marking as fixed.

commit 887d5d2b0de6b28fde22140b6f6abb82c2173211

Seth Leger December 4, 2013 at 12:34 PM

I'm getting this stack trace in 1.12.2-SNAPSHOT:

Caused by: org.opennms.web.alarm.AlarmIdNotFoundException: Missing alarm request attribute. at org.apache.jsp.WEB_002dINF.jsp.alarm.detail_jsp._jspService(detail_jsp.java:112) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:109) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:403) ... 97 more

Seth Leger December 4, 2013 at 11:23 AM

The fix for this issue was in commit b6da66570729d61e3632368b9baf8df977d5b91b but it does not fix the problem. There was a problem in the smoke tests that prevented the bug from being detected. Reopening.

Markus von Rüden September 18, 2013 at 5:28 AM

Hey Ben,

as discussed yesterday in our Status Meeting,
I fixed this problem in branch "origin/1.12".

I also cherry picket that commit into branch "origin/space/13.2"

If you need anything else, let me know.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created September 18, 2013 at 5:25 AM
Updated January 27, 2017 at 4:21 PM
Resolved December 4, 2013 at 4:39 PM

Flag notifications