Display the Package Name and Service Parameters on the Service Page
Description
Environment
Acceptance / Success Criteria
Lucidchart Diagrams
Activity
Alejandro Galue May 16, 2013 at 3:41 AM
Current Features:
1. Display the Poller Package selected for the service.
2. Display the Monitor Class associated with the service.
3. Display the configured service parameters.
3. Do not display password fields (for security reasons).
4. Display the complex XML parameters (PageSequenceMonitor, MailTransportMonitor)
All those features are available on 1.10 and 1.12
Some of the enhancements have been added on the following revisions:
1.10: 06e578dba3a646d36703f0c34a0bbcdc8c298e7b
1.12: 2db49574f5b0d7159fefaa7ad3e06f604b12f451
IMPORTANT: Each version has their own implementation, so do not merge changes made on one version into another.
Alejandro Galue May 15, 2013 at 3:55 AM
Fixed on revision 4f1831fecbc973219dce4ffb14224d6caf2e6458 for 1.10, and merged into 1.12 on revision f539c5393a4187424160d4a1d25b20f595f679c7
Alejandro Galue May 15, 2013 at 3:52 AM
Ben,
I just figured out that service.jsp is on a different place on 1.12
On 1.10 it is located at opennms-webapp/src/main/webapp/element/service.jsp; but in 1.12 it is located at opennms-webapp/src/main/webapp/WEB-INF/jsp/element/service.jsp (and I believe it is managed through defaultViewResolver), and their internal structure is completely different (because it uses the Spring MVC style).
For this reason, I reworked the solution and I tested it on my own system, so the equivalent behavior works exactly as the original solution for 1.10.
Benjamin Reed May 14, 2013 at 10:12 PM
In case you missed my email, I had issues merging this patch to 1.12, Alejandro. I'm not confident enough in how it should apply to the 1.12 version of the code, so I've left it for you.
I know that adding new features to 1.10 is not a good idea at the moment, but this is just a small change on element/service.jsp that provides a huge and very useful information, by reducing the time on troubleshooting poller configuration.