Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

No decode for nodelabel in nodeUp/nodeDown event

Description

the nodeDown/nodeUp events have no decoded nodelabel parms

This has been fixed in 1.8 bades fetaures/TN branch

MacBook-Pro-di-Antonio-Russo:opennms antonio$ git show ae82e28192635bec5483c380abf0d6b1f4119fca
commit ae82e28192635bec5483c380abf0d6b1f4119fca
Author: Antonio <rssntn67@yahoo.it>
Date: Wed Feb 29 21:35:55 2012 +0100

Fixed nodelabel event parms

the nodeDown event has no nodelabel parms.

diff --git a/opennms-services/src/main/java/org/opennms/netmgt/poller/DefaultPollContext.java b/opennms-services/src/main/java/org/opennms/net
index f469211..743dd87 100644
— a/opennms-services/src/main/java/org/opennms/netmgt/poller/DefaultPollContext.java
+++ b/opennms-services/src/main/java/org/opennms/netmgt/poller/DefaultPollContext.java
@@ -268,7 +268,7 @@ public class DefaultPollContext implements PollContext, EventListener {

// For node level events (nodeUp/nodeDown) retrieve the
// node's nodeLabel value and add it as a parm

  • else if (uei.equals(EventConstants.NODE_UP_EVENT_UEI)
    + if (uei.equals(EventConstants.NODE_UP_EVENT_UEI)
    || uei.equals(EventConstants.NODE_DOWN_EVENT_UEI)) {


String nodeLabel = this.getNodeLabel(nodeId);

Environment

Java 6

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Antonio Russo February 9, 2013 at 5:52 AM

I see in 1.10 is fixed!

Antonio Russo February 9, 2013 at 4:42 AM

Ben this is now in TN-master...and because I have a clear run in bamboo it seems that will be reasonably merged soon.
I'm going to fix this in 1.10

Benjamin Reed September 28, 2012 at 10:16 AM

Antonio, this fix should also be in 1.10 and up, right? I'm not seeing it in 1.10.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created September 26, 2012 at 7:58 AM
Updated January 27, 2017 at 4:21 PM
Resolved March 1, 2013 at 7:54 AM

Flag notifications