Improve JRobinRrdStrategy createGraphDef error messages

Description

If you have an invalid rrd graph command inside snmp-graph.properties, it would be nice if instead of a big stacktrace exception you would get a shorter message of the problem.

For example, if you had a definition entry like:

DEF:inMax:{rrd1}:udpInDatagrams:MAX

It would be nice to see a message like:

Invalid definition: DEF:inMax:{rrd1}:udpInDatagrams:MAX

instead of a stack trace of:

Caused by: org.opennms.netmgt.rrd.RrdException: An exception occurred creating the graph: 1
at org.opennms.netmgt.rrd.jrobin.JRobinRrdStrategy.createGraphReturnDetails(JRobinRrdStrategy.java:370)
at org.opennms.netmgt.rrd.jrobin.JRobinRrdStrategy.createGraph(JRobinRrdStrategy.java:333)
at org.opennms.netmgt.rrd.QueuingRrdStrategy.createGraph(QueuingRrdStrategy.java:1063)
at org.opennms.netmgt.dao.support.DefaultRrdDao.createGraph(DefaultRrdDao.java:210)
... 87 more

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Details

Assignee

Reporter

Labels

Components

Affects versions

Priority

PagerDuty

Created August 2, 2012 at 2:29 PM
Updated September 21, 2021 at 9:14 PM