Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

manager log messages are too vague or wrong level.

Description

If you turn DEBUG on for OpenNMS.Manager, you get log messages like:

2012-07-30 15:04:13,656 DEBUG [Main] Invoker: Invocation successful.
2012-07-30 15:04:13,656 DEBUG [Main] Invoker: completed pass 1
2012-07-30 15:04:13,656 DEBUG [Main] Starter: Startup complete

which are kind of vague as to what exactly they mean. "Invocation successful" for what?

Also there are these messages at INFO:
2012-07-27 16:33:55,002 INFO [Main] Starter: Found file 'jcifs.properties' at '/opt/opennms/etc/jcifs.properties'. Setting 'jcifs.properties' to this path.
2012-07-27 16:33:55,296 INFO [Main] Manager: Using ICMP implementation: org.opennms.netmgt.icmp.jni6.Jni6Pinger
2012-07-27 16:33:55,297 INFO [Main] Manager: IPv4 ICMP available? true
2012-07-27 16:33:55,297 INFO [Main] Manager: IPv6 ICMP available? true

Shouldn't these be DEBUG?

Acceptance / Success Criteria

None

Attachments

1

Lucidchart Diagrams

Activity

Seth Leger August 15, 2013 at 3:28 PM

Fixed the log message in Invoker.java. The ICMP messages are probably good at INFO since it is important to see which pinger implementation is in use. Marking as fixed.

commit a1b5291d0a2fdf3bd298894ceaffd233001e8cdf

Ron Roskens August 15, 2012 at 5:40 PM

I suspect that the ICMP messages are part of OpenNMS:Name=TestLoadLibraries since they occur like this:

2012-08-15 15:59:20,228 DEBUG [Main] Invoker: pass 0 on service OpenNMS:Name=TestLoadLibraries will invoke method "doTestLoadLibraries"
2012-08-15 15:59:20,228 DEBUG [Main] Invoker: Invoking doTestLoadLibraries on object OpenNMS:Name=TestLoadLibraries
2012-08-15 15:59:20,291 INFO [Main] Manager: Using ICMP implementation: org.opennms.netmgt.icmp.jni6.Jni6Pinger
2012-08-15 15:59:20,291 INFO [Main] Manager: IPv4 ICMP available? true
2012-08-15 15:59:20,291 INFO [Main] Manager: IPv6 ICMP available? true
2012-08-15 15:59:20,292 DEBUG [Main] Invoker: Invocation start successful for object OpenNMS:Name=TestLoadLibraries

Ron Roskens August 15, 2012 at 5:38 PM

0001-NMS-5467-log-method-mbean-on-succesfull-invocation-a.patch changes the successful message from debug to info, and logs the method and mbean object name.

2012-08-15 16:01:11,921 DEBUG [Main] Invoker: Invoking start on object OpenNMS:Name=Syslogd
2012-08-15 16:01:11,965 INFO [Main] Invoker: Invocation start successful for object OpenNMS:Name=Syslogd

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created July 30, 2012 at 6:04 PM
Updated January 27, 2017 at 4:20 PM
Resolved August 15, 2013 at 3:28 PM