many default graph definitions include unreferenced min/max DEFs and CDEFs
Description
There seems to be an issue with a default graph definition template that generates excessive definitions never used in drawing lines or printing values on a graph.
I don't have git setup, so I'll give an example using report.mib2.bits. Lines greatly indented are what I see as extraneous, and these appear in a lot of graph definitions since sometime around 1.9.90.
Possible sanity check needed, but the min/max DEF/CDEFs above neither are referenced by other definitions, nor called by AREA or GPRINT commands. The min/max actually used in the graph definition are based upon collected MIN/MAX (via RRA definitions).
I think a list could be generated by grep'ing for DEF:min (max) or CDEF:min (max)
I see this in the majority of, but not every, graph definition EXCEPT hr., liebert, cisco.ids* , dell.rac* , openmanage*, mib2printer*, framerelay*, brocade*, fortinet*, xmp*, bgp*, mcast.ietf.msdp* (but mcast.ietf.improute* has them), mcast.ietf.igmp*, mcast.ietf.l3vpn*, (mcast.ietf.cisco* has them), mcast.cisco.pm*, mcast.cisco.igmpsnoop*, mcast.juniper*, riverbed.steelhead*, sofaware*, servertech*, force10*, sensorProbe*, cyclades*, zeus*, adonis*, ive*, sgProxy*, mysql*,
Most are found in the upper half of the definition file.
If you look at report.cyclades.cur, you can see "Max" prefix correctly used, but just because that is part of the collection variable name. The CDEF:MaxCurrent is still based on a variable built from an AVERAGE collected value, and MIN MAX from RRAs are still used for those respective values.
Environment
snmp-graph.properties
Acceptance / Success Criteria
None
Lucidchart Diagrams
Activity
Show:
Seth Leger June 20, 2016 at 8:50 AM
I feel like Tarus was looking at something like this recently. Reassigning.
There seems to be an issue with a default graph definition template that generates excessive definitions never used in drawing lines or printing values on a graph.
I don't have git setup, so I'll give an example using report.mib2.bits. Lines greatly indented are what I see as extraneous, and these appear in a lot of graph definitions since sometime around 1.9.90.
Possible sanity check needed, but the min/max DEF/CDEFs above neither are referenced by other definitions, nor called by AREA or GPRINT commands. The min/max actually used in the graph definition are based upon collected MIN/MAX (via RRA definitions).
I think a list could be generated by grep'ing for DEF:min (max) or CDEF:min (max)
I see this in the majority of, but not every, graph definition EXCEPT hr., liebert, cisco.ids* , dell.rac* , openmanage*, mib2printer*, framerelay*, brocade*, fortinet*, xmp*, bgp*, mcast.ietf.msdp* (but mcast.ietf.improute* has them), mcast.ietf.igmp*, mcast.ietf.l3vpn*, (mcast.ietf.cisco* has them), mcast.cisco.pm*, mcast.cisco.igmpsnoop*, mcast.juniper*, riverbed.steelhead*, sofaware*, servertech*, force10*, sensorProbe*, cyclades*, zeus*, adonis*, ive*, sgProxy*, mysql*,
Most are found in the upper half of the definition file.
If you look at report.cyclades.cur, you can see "Max" prefix correctly used, but just because that is part of the collection variable name. The CDEF:MaxCurrent is still based on a variable built from an AVERAGE collected value, and MIN MAX from RRAs are still used for those respective values.