RadiusAuthenticationProvider.java Tests against wrong variable.
Description
RadiusAuthenticationProvider.java in opennms/features/springframework-security/src/main/java/org/opennms/web/springframework/security Has the following code which tests the wrong variable:
RadiusAuthenticationProvider.java
public RadiusAuthenticationProvider(String server, String secret) { Assert.hasLength(server, "A server must be specified"); this.server = server; Assert.hasLength(server, "A shared secret must be specified"); this.secret = secret; }
Assert.hasLength(server, "A shared secret must be specified"); should be Assert.hasLength(secret, "A shared secret must be specified");
Acceptance / Success Criteria
None
Lucidchart Diagrams
Activity
Show:
Alejandro Galue September 19, 2011 at 1:27 PM
Thanks for catching this.
Fixed on revision c6092bace792bb2be0bfb1bb479c298fac573584 for 1.10
RadiusAuthenticationProvider.java in
opennms/features/springframework-security/src/main/java/org/opennms/web/springframework/security
Has the following code which tests the wrong variable:
RadiusAuthenticationProvider.java
public RadiusAuthenticationProvider(String server, String secret) {
Assert.hasLength(server, "A server must be specified");
this.server = server;
Assert.hasLength(server, "A shared secret must be specified");
this.secret = secret;
}
Assert.hasLength(server, "A shared secret must be specified");
should be
Assert.hasLength(secret, "A shared secret must be specified");