Refactor SnmpPoller
Description
Environment
Acceptance / Success Criteria
Lucidchart Diagrams
Activity
Former user March 8, 2010 at 5:30 PM
fixed in master: 56b745e..775db7c master -> master
Former user March 7, 2010 at 4:36 PM
Anyway the snmppoller is not enabled by default.....
You know!
Former user March 7, 2010 at 4:35 PM
Yeah!
I'll fix this tomorrow if this is ok for you and I commit the changes tomorrow evening (CET)
I'll re add the "deprecated" attributes!
Benjamin Reed March 7, 2010 at 4:06 PM
It's hard to tell what's actually used if someone tried to use some XML tool to generate configs. If they really should not be used, they should be left in the XSD and marked as deprecated/unused, at the very least, IMHO.
As for 1.7.10, the release candidate branch was created a week ago, anything new has to be specifically ported over to it, and this seems to be an invasive enough change that it should get some testing in snapshots before it goes live after being committed the Saturday before release.
Former user March 7, 2010 at 3:42 PM
I only changed unused properties of snmppoller.
The firsr one was an unusual snmp prop[erty of Interface object to limit the number of interfaces send in the GET request (but there is MaxVarPerPdu...for that...and I can be aware of the fact that no one is using it.
The latter suppressadminDown event is not useful becouse I change the way the events are generated.
And here follows the explanation also for the alarm definition....
Let me try to explain:
I only send events when a status is changed here are the chenges that can happen:
First of all let me consider the following situation:
Admin/Oper is the sequence:
First case:
Up/Up ---> Up/Down : the interfaceOperDown event is generated
Up/Up ---> Down/Down : the interfaceAdminDown event is generated
Up/Down ----> Up/Up the interfaceOperUp event is generated
Down/Down ----> Up/Up the interfaceOperUp event is generated
Down/Down ----> Up/ANy The interfaceAdminUp event is generated
Let me rethink the alarms definition...becouse it is clear that an interfaceOperUp will clear either
an interfaceAdminDown as an InterfaceOperDown event.....but what to do with the interfaceAdminUp event? do this close an interfaceOperDown event?
I think that this changes are very important and that they really have no impact on 1.7.10 and then they should be released with that!
The Poller Snmp need to be refactored:
a) There are a lot of exception when updating the information to the database
b) The structure need to be revisited for a better object model
c) the event management must be simplified according with a more simple rule.