Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Some Servlets do not recalculate the Base URL in redirects

Description

There are a few servlets that bypass the Util.calculateUrlBase() rules, which can cause problems with "Layer 7" capable hardware load balancers in some situations (i.e. ProxyPass implementation). Especially if these devices are capable of re-writing URLs and HTTP headers when redirecting (i.e. for Foundry VIPs).

I've identified this in 2 places in the UI, but I don't know if it exists in others:

NodeLabelChangeServlet.java
NodeRescanServlet.java

Diff's attached.

Environment

Operating System: All Platform: PC

Acceptance / Success Criteria

None

Attachments

1
  • 17 Sep 2009, 07:05 PM

Lucidchart Diagrams

Activity

Show:

Benjamin Reed March 8, 2010 at 4:03 PM

cherry-picked to 1.7.10 in 7f33681b9493e2c789a0f9eb5f10d5b675c984fd
... and 1.6.10:
[rc/stable/1.6.10 395b62b] Fixed https://opennms.atlassian.net/browse/NMS-3386#icft=NMS-3386 by changing raw getContextPath() calls into calls to Util.calculateUrlBase(request). http://bugzilla.opennms.org/show_bug.cgi?id=3348

Seth Leger (community account) March 4, 2010 at 5:41 PM

Applied this fix to master for inclusion in 1.7. Marking as fixed.

commit a10411854928e88e855261dd3ae474a7323e9bf5

Bill Dymek September 17, 2009 at 7:05 PM

Created an attachment (id=876)
url rewrite proof-of-concept

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created September 17, 2009 at 7:05 PM
Updated January 27, 2017 at 4:25 PM
Resolved March 8, 2010 at 4:03 PM

Flag notifications