KSC Report list is reordered every time a new report is added

Description

This causes the id to change and thus we cannot reference this KSC/report externally and if you do it will break very easily.

Tarus told me to definitely bug this one.

Environment

Operating System: All Platform: All

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

DJ Gregor October 19, 2008 at 10:33 AM

Note: the display order was changed as part of the fix for this bug or another change. It was changed back as part of .

DJ Gregor February 3, 2008 at 11:00 PM

Fixed in revision 8334:

  • Fix for bug#2216 – KSC Report list is reordered every time a new report is added.

  • A unique ID is assigned to each KSC report, is persisted across edits, and is used instead of the report's index in the KSC configuration file everywhere, particularly in URLs. The ID is initialized to be the report's index (starting at 0) in the KSC configuration file and is persisted the first time changes are saved to the file during normal editing.

  • Instead of having a set of fields in the KSC_PerformanceReportFactory that track what report and graph are being editing, move this to the new KscReportEditor object along with related methods and store this object in the user's session.

  • Use Asserts in afterPropertiesSet and other methods to simplify things.

  • Format code in a few places.

  • Refactor some controller handleRequestInternal() methods.

Tarus Balog January 23, 2008 at 7:02 AM

Ah, I was going to open a bug on this myself. The problem is that some people want to static link to KSC reports, so since the URL changes if the alphabetical order changes in the list, that makes it impossible.

If you were to add "KSC number two and a half" to your list, the URL for "KSC number three" would change.

Jeff Gehlbach January 23, 2008 at 1:26 AM

Just to clarify, since I was confused at first about the circumstances to reproduce this bug:

Starting with a system with no KSC reports defined,

1. Add a report titled "KSC number one"
2. Add another report titled "KSC number two"
3. Add a third report titled "KSC number three"

Now go look at the list of available reports in the web UI, you will see that the order is apparently alphabetical ("KSC number three" comes second now).

Fixed

Details

Assignee

Reporter

Fix versions

Affects versions

Priority

PagerDuty

Created January 22, 2008 at 5:23 PM
Updated January 27, 2017 at 4:27 PM
Resolved October 19, 2008 at 10:33 AM