Grafana Dashboard report fails on "row"

Description

If a Grafana dashboard includes a row, the report renderer will fail with an error about a null datasource element.  Rows are a type of panel, but don't have any data associated with them.  

Ideally, the row should just render the contents of the "title" element as text on the report.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Alberto October 17, 2022 at 6:36 PM

Merged to Release-30.x

Fixed issue when Panel type row from older versions is passed (which has a datasource value of null)

Currently Panel type row is not being printed in the report. I think this should be handled on a different jira as an enhancement (see below)

 
opennms/integrations/opennms-jasper-extensions/src/main/java/org/opennms/netmgt/jasper/grafana/GrafanaPanelDatasource.java

Line 78 in 07024cd

panels = dashboard.getPanels().stream()

Jeff Gehlbach October 17, 2022 at 2:36 PM

If possible, let's ignore the presence of Rows and render all Panels as if they existed without any Row structure.

Alberto October 15, 2022 at 2:17 PM

The code currently doesn't print Panels type row, I did fix the issue that creates the error. But I rather handle the inclusion of a Pane; row as an ehancement since currently is not part of it.

 

What do you think should I create another Jira for that or should I do that in this ticket together with the fix? It might take me more time to understand how jasper works though.

Jeff Gehlbach September 27, 2022 at 6:03 PM

I've bumped into an issue that sounds exactly like this one, but didn't have the time to dig into the cause. Glad we've got a bead on it now.

Fixed

Details

Assignee

Reporter

HB Grooming Date

HB Backlog Status

Components

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created September 26, 2022 at 11:14 PM
Updated November 8, 2022 at 4:15 PM
Resolved October 17, 2022 at 6:36 PM