Remove feedback submission actions from Opennms so that OCE is the authoritative source of situation changes

Description

Currently Opennms takes action when feedback is submitted. It will remove an alarm from a situation for example. We will change this behaviour so that Opennms does not take action directly on feedback submission besides persisting the feedback and notifying handlers (sending to kafka for now).

This way we rely on OCE taking action on the feedback and notifying Opennms via a situation record with the changes applied. This will avoid race conditions that may arise due to having two entities taking action on feedback. It also helps to encapsulate all of the situation logic on the OCE.

In order fo this to work we will need to update how Opennms handles received situations. Currently when the list of alarms are recorded for a situation they are performed additively. In order to remove alarms from situations we will need to treat the OCE situation source as authoritative and record the list as it told us (removing any alarms that are no longer present).

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Matthew Brooks November 13, 2018 at 5:05 PM

Fixed

Details

Assignee

Reporter

Sprint

Fix versions

Priority

PagerDuty

Created November 2, 2018 at 4:54 PM
Updated June 3, 2019 at 8:06 AM
Resolved November 19, 2018 at 1:58 PM