Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Move TrapNotificationListener interface from Trapd to TrapReceiverSnmp4jImpl

Description

Currently, Trapd itself has the TrapNotificationListener interface and registers itself to listen for traps. We should separate this out into another class so that Trapd only contains the lifecycle methods.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Seth Leger March 29, 2016 at 10:48 AM

All changes are done, marking as fixed.

Deepak Patel March 29, 2016 at 7:18 AM

I have created a new branch(feature-refactor-trapd-HZN-609-1) from feature-refactor-trapd. chages are done & created a pull request.

Seth Leger March 24, 2016 at 10:41 AM

Hi Deepak, as part of the work on this issue, we removed and then restored the TrapProcessorFactory on Trapd. After my latest changes, it now needs to be removed.

Please create a new branch from feature-refactor-trapd and revert the changes from commit 260cde76dcf997160f47255366ab8e887515fd38.

Deepak Patel March 17, 2016 at 12:16 AM

I have made all the changes suggested by you, please review & let me know your comments.
There is one extra change which I have done is to create an implementation class TrapdConfigBean for TrapdConfig (referring SyslogConfigBean)

Seth Leger March 16, 2016 at 5:17 PM

Once these changes are completed, the features/events/traps project should not have any compilation errors.

Fixed

Details

Assignee

Reporter

Story Points

Components

Sprint

Fix versions

Affects versions

Priority

Parent

PagerDuty

Created March 10, 2016 at 10:20 AM
Updated June 3, 2019 at 8:05 AM
Resolved March 29, 2016 at 10:48 AM