Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

JNA Pinger fails with NPE

Description

When running as non-root and using a Linux kernel < 3.11, the JNA pinger fails with this stack trace:

Caused by: com.google.common.util.concurrent.UncheckedExecutionException: java.lang.NullPointerException at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2203)[18:com.google.guava:18.0.0] at com.google.common.cache.LocalCache.get(LocalCache.java:3937)[18:com.google.guava:18.0.0] at com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4739)[18:com.google.guava:18.0.0] at org.opennms.netmgt.icmp.AbstractPingerFactory.getInstance(AbstractPingerFactory.java:70)[245:org.opennms.opennms-icmp-api:19.0.0.SNAPSHOT] ... 27 more Caused by: java.lang.NullPointerException at org.opennms.netmgt.icmp.jna.JnaIcmpMessenger.setTrafficClass(JnaIcmpMessenger.java:115)[246:org.opennms.opennms-icmp-jna:19.0.0.SNAPSHOT] at org.opennms.netmgt.icmp.jna.JnaPinger.setTrafficClass(JnaPinger.java:269)[246:org.opennms.opennms-icmp-jna:19.0.0.SNAPSHOT] at org.opennms.netmgt.icmp.AbstractPingerFactory$1.call(AbstractPingerFactory.java:74)[245:org.opennms.opennms-icmp-api:19.0.0.SNAPSHOT]

The failure is inevitable in this case, but we should avoid throwing an NPE and log a more suitable exception.

Also, request made using the PingRpcModule or PingSweepRpcModule will fail with a time-out if this occurs on a Minion. We should have those requests fail immediately instead.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Jesse White April 4, 2017 at 12:23 PM

This shouldn't occur anymore now that the "best" pinger is enabled by default - see https://opennms.atlassian.net/browse/NMS-9078#icft=NMS-9078.

fooker March 15, 2017 at 8:36 AM

I really can't reproduce. Can we just close this in relation to #HZN-954?

Won't Fix

Details

Assignee

Reporter

Sprint

Affects versions

Priority

Parent

PagerDuty

Created November 21, 2016 at 11:33 AM
Updated June 3, 2019 at 8:04 AM
Resolved April 4, 2017 at 12:23 PM

Flag notifications