Exception stack returned when attempting to import an invalid enterpriseId

Description

When testing imports and an invalid enterpriseId is given, an exception is returned as included below. It would be more customer friendly to handle the exception and return a message indicating an issue with the ID.

Requisition retrieval failed with: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: argument "content" is null java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: argument "content" is null at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395) at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2022) at org.opennms.netmgt.provision.requisition.command.ShowImport.execute(ShowImport.java:96) at org.apache.karaf.shell.impl.action.command.ActionCommand.execute(ActionCommand.java:84) at org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:68) at org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:86) at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:599) at org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:526) at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:415) at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:416) at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:229) at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.lang.IllegalArgumentException: argument "content" is null at com.fasterxml.jackson.databind.ObjectMapper._assertNotNull(ObjectMapper.java:4885) at com.fasterxml.jackson.databind.ObjectMapper.readTree(ObjectMapper.java:3122) at org.opennms.velocloud.client.v1.VelocloudApiCustomerClientV1.getState(VelocloudApiCustomerClientV1.java:406) at org.opennms.velocloud.client.v1.VelocloudApiCustomerClientV1.lambda$getDatacenters$10(VelocloudApiCustomerClientV1.java:421) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) at org.opennms.velocloud.client.v1.VelocloudApiCustomerClientV1.getDatacenters(VelocloudApiCustomerClientV1.java:424) at org.opennms.velocloud.requisition.CustomerRequisitionProvider.handleRequest(CustomerRequisitionProvider.java:200) at org.opennms.velocloud.requisition.AbstractRequisitionProvider.getRequisition(AbstractRequisitionProvider.java:101) at Proxydaf5afa5_c3c1_4cd9_bb26_8181317f1863.getRequisition(Unknown Source) at org.opennms.features.apilayer.common.requisition.RequisitionProviderImpl.getRequisition(RequisitionProviderImpl.java:64) at org.opennms.netmgt.provision.persist.rpc.RequisitionRpcModule$1.get(RequisitionRpcModule.java:81) at org.opennms.netmgt.provision.persist.rpc.RequisitionRpcModule$1.get(RequisitionRpcModule.java:70) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700) ... 3 more

Environment

None

Activity

Show:

Details

Assignee

Reporter

Affects versions

Priority

PagerDuty

Created August 30, 2023 at 6:23 PM
Updated September 8, 2023 at 8:16 PM

Flag notifications